coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

rm: fix gnu coreutils test one-file-system.sh

Open mattsu2020 opened this issue 1 month ago • 5 comments

Summary

Remove the extra leading rm: from the rm-error-preserve-root-all locale strings so the message matches expected test output. Keep wording otherwise unchanged across en-US and fr-FR locales.

#9127

mattsu2020 avatar Nov 20 '25 23:11 mattsu2020

GNU testsuite comparison:

Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions[bot] avatar Nov 21 '25 00:11 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions[bot] avatar Nov 21 '25 23:11 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions[bot] avatar Nov 22 '25 09:11 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions[bot] avatar Dec 01 '25 13:12 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions[bot] avatar Dec 02 '25 12:12 github-actions[bot]

CodSpeed Performance Report

Merging #9428 will degrade performances by 2.36%

Comparing mattsu2020:rm_compatibility (01ac5f3) with main (06d843f)

Summary

❌ 1 regression
✅ 126 untouched
⏩ 6 skipped[^skipped]

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
rm_force_files 2 ms 2.1 ms -2.36%
[^skipped]: 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

codspeed-hq[bot] avatar Dec 15 '25 12:12 codspeed-hq[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions[bot] avatar Dec 15 '25 12:12 github-actions[bot]