coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

tsort: gnu misc tsort.pl

Open mattsu2020 opened this issue 1 month ago • 7 comments

Summary

Align tsort with GNU behavior: silently accept -w, reorder successors to produce GNU’s deterministic output, and surface loop errors with the new util: error: … prefix via clap_localization::print_prefixed_error. Adjust uniq, comm, tsort, and chroot tests to expect the prefixed error strings so they continue to pass with the updated localization handling. Keep the test fixtures and assertions consistent with the updated message format across the suite.

Tests

cargo test test_tsort cargo test test_uniq (including gnu_tests) cargo test test_chroot --features chroot

mattsu2020 avatar Nov 15 '25 12:11 mattsu2020

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Nov 15 '25 14:11 github-actions[bot]

CodSpeed Performance Report

Merging #9289 will improve performances by 2.03%

Comparing mattsu2020:tsort_compatibility (7d21d9c) with main (0f5ab81)

Summary

⚡ 1 improvement
✅ 125 untouched
⏩ 6 skipped[^skipped]

Benchmarks breakdown

Benchmark BASE HEAD Change
du_max_depth_balanced_tree[(6, 4, 10)] 33.1 ms 32.4 ms +2.03%
[^skipped]: 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

codspeed-hq[bot] avatar Nov 16 '25 02:11 codspeed-hq[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Nov 16 '25 02:11 github-actions[bot]

is it expected that tsort.pl doesn't pass yet? thanks

sylvestre avatar Dec 01 '25 12:12 sylvestre

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/tsort is no longer failing!

github-actions[bot] avatar Dec 01 '25 13:12 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/misc/tsort is no longer failing!

github-actions[bot] avatar Dec 02 '25 11:12 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/misc/tsort is no longer failing!

github-actions[bot] avatar Dec 03 '25 09:12 github-actions[bot]