coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

fix(tac):gnu tac-2-nonseekable.sh test

Open mattsu2020 opened this issue 1 month ago • 9 comments

Add a new function ensure_stdin_open() that uses the nix crate to check if stdin is open before attempting to read from it. This prevents potential errors when stdin is closed, improving robustness of the tac command on Unix systems. Updated dependencies to include nix in Cargo.toml and Cargo.lock.

relate https://github.com/uutils/coreutils/issues/9127

mattsu2020 avatar Nov 04 '25 04:11 mattsu2020

CodSpeed Performance Report

Merging #9137 will not alter performance

Comparing mattsu2020:tac_compatibility (c768673) with main (06d843f)

Summary

✅ 127 untouched
⏩ 6 skipped[^skipped]

[^skipped]: 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

codspeed-hq[bot] avatar Nov 04 '25 04:11 codspeed-hq[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Nov 04 '25 04:11 github-actions[bot]

the test doesn't seem to pass ?!

sylvestre avatar Nov 08 '25 08:11 sylvestre


2025-11-04T04:38:10.6776687Z FAIL: tests/tac/tac-2-nonseekable
2025-11-04T04:38:10.6776753Z =================================
2025-11-04T04:38:10.6776756Z 
2025-11-04T04:38:10.6776872Z FAIL tests/tac/tac-2-nonseekable.sh (exit status: 1)

sylvestre avatar Nov 08 '25 10:11 sylvestre

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Nov 08 '25 12:11 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/tac/tac-2-nonseekable is no longer failing!

github-actions[bot] avatar Nov 08 '25 13:11 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/tac/tac-2-nonseekable is no longer failing!

github-actions[bot] avatar Nov 10 '25 01:11 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/tac/tac-2-nonseekable is no longer failing!

github-actions[bot] avatar Dec 01 '25 12:12 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/tac/tac-2-nonseekable is no longer failing!

github-actions[bot] avatar Dec 02 '25 12:12 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tac/tac-2-nonseekable is no longer failing!

github-actions[bot] avatar Dec 15 '25 12:12 github-actions[bot]

Does this make it change compatibility for when the input is /dev/null ?

ChrisDryden avatar Dec 15 '25 13:12 ChrisDryden

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Dec 15 '25 23:12 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Dec 16 '25 00:12 github-actions[bot]