coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

cksum: Add SHA3/SHAKE support

Open naoNao89 opened this issue 2 months ago • 20 comments

Add comprehensive tests for SHA3/SHAKE algorithm support

This PR adds comprehensive test coverage for SHA3 and SHAKE algorithms with the --length parameter.

The SHA3/SHAKE implementation was already merged into main. This PR ensures the algorithms are properly tested with various length parameters and edge cases.

Fixes #8933 (test coverage aspect)

naoNao89 avatar Oct 18 '25 03:10 naoNao89

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum is no longer failing!

github-actions[bot] avatar Oct 18 '25 04:10 github-actions[bot]

Could you please add tests to make sure we don't regress in the future? Thanks

sylvestre avatar Oct 18 '25 09:10 sylvestre

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum is no longer failing!

github-actions[bot] avatar Oct 20 '25 00:10 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum is no longer failing!

github-actions[bot] avatar Oct 21 '25 05:10 github-actions[bot]

please move the --debug implementation in a different PR

sylvestre avatar Oct 21 '25 11:10 sylvestre

sr, i missed pushing the commit from 8949 to 8948 🤡

naoNao89 avatar Oct 21 '25 11:10 naoNao89

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum is no longer failing!

github-actions[bot] avatar Oct 21 '25 11:10 github-actions[bot]

CodSpeed Performance Report

Merging #8948 will not alter performance

Comparing naoNao89:fix-cksum-sha3-debug-8933 (2e90544) with main (5b261bc)

Summary

✅ 127 untouched
⏩ 6 skipped[^skipped]

[^skipped]: 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

codspeed-hq[bot] avatar Oct 30 '25 05:10 codspeed-hq[bot]

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-base64. tests/cksum/cksum-base64 is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Oct 30 '25 06:10 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Oct 30 '25 07:10 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Oct 31 '25 10:10 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Oct 31 '25 12:10 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Nov 03 '25 04:11 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Nov 03 '25 05:11 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Nov 03 '25 06:11 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Nov 03 '25 07:11 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Nov 07 '25 11:11 github-actions[bot]

@naoNao89 do you want to still land this? thanks

sylvestre avatar Dec 05 '25 21:12 sylvestre

am here

naoNao89 avatar Dec 06 '25 06:12 naoNao89

GNU testsuite comparison:

Congrats! The gnu test tests/du/files0-from is no longer failing!

github-actions[bot] avatar Dec 06 '25 08:12 github-actions[bot]