coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

Bump `libc` & fix clippy errors on FreeBSD

Open cakebaker opened this issue 3 months ago • 16 comments

This PR bumps libc from 0.2.175 to 0.2.1760.2.178 and fixes two clippy errors from the useless_conversion lint on FreeBSD (see https://github.com/uutils/coreutils/actions/runs/17946395896/job/51033759647?pr=8717#step:5:4493).

cakebaker avatar Sep 23 '25 16:09 cakebaker

CodSpeed Performance Report

Merging #8722 will not alter performance

Comparing cakebaker:bump_libc (e24182c) with main (0f5ab81)

Summary

✅ 126 untouched
⏩ 6 skipped[^skipped]

[^skipped]: 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

codspeed-hq[bot] avatar Sep 23 '25 17:09 codspeed-hq[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Sep 23 '25 17:09 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Oct 13 '25 15:10 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Oct 16 '25 02:10 github-actions[bot]

Difficult?

oech3 avatar Dec 03 '25 08:12 oech3

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Dec 03 '25 09:12 github-actions[bot]

@oech3 it's difficult insofar as I don't know FreeBSD. In the latest push I disabled the useless_conversion lint.

cakebaker avatar Dec 03 '25 10:12 cakebaker

@lcheylus Any idea about lint on FreeBSD?

oech3 avatar Dec 03 '25 10:12 oech3

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Dec 03 '25 10:12 github-actions[bot]

@oech3 it looks like the lint wasn't the problem as the df tests still fail :|

cakebaker avatar Dec 03 '25 10:12 cakebaker

https://github.com/uutils/coreutils/actions/runs/19890309614/job/57007243757?pr=8722#step:5:5833 warning: failed to register USDT probes: No such file or directory (os error 2) ???

oech3 avatar Dec 03 '25 12:12 oech3

A question: removate bot is updating Cargo.lock is only and leaving Cargo.toml's libc. Is it OK and does not cause any collision? cargo (of Arch Linux at least) builds both version of libc crate.

oech3 avatar Dec 08 '25 11:12 oech3

@lcheylus Any idea about breakage of FreeBSD by bumping crate?

oech3 avatar Dec 09 '25 14:12 oech3

@lcheylus Any idea about breakage of FreeBSD by bumping crate?

No, I have no clue why some tests fail for df command with blocksize on FreeBSD.

lcheylus avatar Dec 09 '25 17:12 lcheylus

Oh... @cakebaker how about 0.0.001 version bump?

oech3 avatar Dec 09 '25 17:12 oech3

On Arch Linux, libc 0.2.178 broke uu_date now...

oech3 avatar Dec 19 '25 21:12 oech3