coreutils
coreutils copied to clipboard
timeout: catch TERM signal
fixes #8040
set a signal handler and terminate child process on receiving SIGTERM.
I'm a bit confused about how to write tests for it, is it appropriate to use ps and kill in ci?
GNU testsuite comparison:
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
GNU testsuite comparison:
Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
I have added a very similar test for sleep and SIGSEGV. You can probably write a very similar test.
@Luv-Ray : I tried to write a test. Feel free to integrate it to your pull request: https://github.com/martinkunkel2/coreutils/commit/e4591cdf8fec016f7589f921e3def88249ac131c
Looks like a good test too
@Luv-Ray : I tried to write a test. Feel free to integrate it to your pull request: martinkunkel2@e4591cd
Thank you so much :heart:
GNU testsuite comparison:
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
@sylvestre could you please retrigger the CICD / Build (macos-13, x86_64-apple-darwin, feat_os_macos, true) (pull_request)? Looks like a sporadic issue
GNU testsuite comparison:
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
@sylvestre : could that one be integrated? I am running into issues with gnu test suite locally as the testsuite uses this feature (send SIGTERM to timeout) and a lot of processes remain active after gnu test suite has completed.
Thanks everyone!