coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

mv: gnu test case `part-hardlink` fix

Open matrixhead opened this issue 1 year ago • 38 comments

fix for #6631

behaviours changed

  • mv will now preserve links during an inter-device move.
  • Previously, mv would silently fail to create a backup when no-target-directory was specified and the destination ended with a / This patch resolves that issue.
  • The progress bar will now work for simple inter-device file moves as well.

matrixhead avatar Aug 11 '24 09:08 matrixhead

GNU testsuite comparison:

Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Aug 11 '24 09:08 github-actions[bot]

Bravo

Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!


sylvestre avatar Aug 11 '24 10:08 sylvestre

GNU testsuite comparison:

Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!

github-actions[bot] avatar Aug 12 '24 18:08 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!

github-actions[bot] avatar Aug 12 '24 19:08 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!

github-actions[bot] avatar Aug 13 '24 04:08 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!

github-actions[bot] avatar Aug 14 '24 04:08 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/mv/hard-link-1 is no longer failing!
Congrats! The gnu test tests/mv/part-hardlink is no longer failing!

github-actions[bot] avatar Sep 08 '24 11:09 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/mv/backup-dir. tests/mv/backup-dir is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Sep 11 '24 08:09 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/mv/backup-dir. tests/mv/backup-dir is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Sep 11 '24 08:09 github-actions[bot]

@BenWiederhake I cleaned up this PR. Now, it focuses solely on the directory copying part. I'll work on verbose output and error reporting next. For now, could you let me know if this approach looks okay?

matrixhead avatar Sep 12 '24 06:09 matrixhead

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Sep 12 '24 06:09 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Sep 12 '24 09:09 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Sep 17 '24 10:09 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Sep 19 '24 17:09 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/mv/perm-1. tests/mv/perm-1 is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Sep 22 '24 10:09 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/mv/perm-1. tests/mv/perm-1 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Sep 22 '24 11:09 github-actions[bot]

@BenWiederhake no not at all also thanks for helping me with this 😃

matrixhead avatar Sep 24 '24 20:09 matrixhead

GNU testsuite comparison:

GNU test failed: tests/mv/perm-1. tests/mv/perm-1 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Sep 25 '24 13:09 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/mv/perm-1. tests/mv/perm-1 is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/timeout/timeout is no longer failing!

github-actions[bot] avatar Sep 25 '24 15:09 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/mv/perm-1. tests/mv/perm-1 is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Sep 29 '24 11:09 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/mv/perm-1. tests/mv/perm-1 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Oct 05 '24 19:10 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/mv/into-self-2. tests/mv/into-self-2 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/leak-fd. tests/mv/leak-fd is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/no-copy. tests/mv/no-copy is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/part-rename. tests/mv/part-rename is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/part-symlink. tests/mv/part-symlink is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mv/to-symlink. tests/mv/to-symlink is passing on 'main'. Maybe you have to rebase?
GNU test error: tests/mv/acl. tests/mv/acl is passing on 'main'. Maybe you have to rebase?
GNU test error: tests/mv/partition-perm. tests/mv/partition-perm is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Oct 06 '24 18:10 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Oct 07 '24 07:10 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Oct 07 '24 22:10 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/rm/rm2 is no longer failing!

github-actions[bot] avatar Oct 08 '24 08:10 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/rm/rm2 is no longer failing!

github-actions[bot] avatar Oct 08 '24 09:10 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/rm/rm2 is no longer failing!

github-actions[bot] avatar Oct 08 '24 10:10 github-actions[bot]

please let me know when it is ready :)

sylvestre avatar Oct 08 '24 11:10 sylvestre

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/rm/rm2 is no longer failing!

github-actions[bot] avatar Oct 08 '24 12:10 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/rm/rm2 is no longer failing!

github-actions[bot] avatar Oct 08 '24 12:10 github-actions[bot]