coreutils
coreutils copied to clipboard
seq: add f128 code paths
-
refactors
uumain -
adds regression test for #6182 (commented out until implementation is done)
-
preliminary implementation of the f128 code path (feature gated)
I'm having issues with
libquadmath.so.0: it loads fine when I run the binary directly (target/debug/coreutils seq ...), but fails when I run the tests (cargo test/cargo nextest run). It might be a weird NixOS issue though.
I'll try using the nightly f128 code tomorrow to verify the tests pass.
GNU testsuite comparison:
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
The main features this needs to work on nightly are impl FromStr for f128 and impl Display for f128.
I tried implementing them by converting to/from BigDecimal, but that is a lot of code (hard to maintain) and I don't think I even did it correctly as a bunch of tests are failing.
I'll keep this as a draft and keep an eye on the f128 stabilization process; whenever FromStr and Display are stabilized I'll give it another try.
If anyone in the future wants to give this a shot, then check the following links:
- Docs on f128: https://doc.rust-lang.org/stable/std/primitive.f128.html
- f128 impl tracking issue: https://github.com/rust-lang/rust/issues/116909
- Wikipedia on IEEE f128: https://en.wikipedia.org/wiki/Quadruple-precision_floating-point_format
@jalil-salame it is still marked as draft, are you still working on it? thanks
The main features this needs to work on nightly are
impl FromStr for f128andimpl Display for f128.I tried implementing them by converting to/from
BigDecimal, but that is a lot of code (hard to maintain) and I don't think I even did it correctly as a bunch of tests are failing.I'll keep this as a draft and keep an eye on the
f128stabilization process; wheneverFromStrandDisplayare stabilized I'll give it another try.If anyone in the future wants to give this a shot, then check the following links:
- Docs on f128: https://doc.rust-lang.org/stable/std/primitive.f128.html
- f128 impl tracking issue: https://github.com/rust-lang/rust/issues/116909
- Wikipedia on IEEE f128: https://en.wikipedia.org/wiki/Quadruple-precision_floating-point_format
It is blocked by these issues, I left it open so that contributors could see this before starting an attempt, if you feel it should be closed/reattempted, feel free to do so
sorry, it needs to be rebased :/
sorry, it needs to be rebased :/
I don't see why it should:
This is blocked on nightly parsing/display support for f128, so until rust-lang/rust#116909 is closed, there is not much progress I can do. I am subscribed to the issue, so once that is resolved I will try to get back to this.
It would be great if you could mark this PR as blocked with a label c:
please reopen when ready