coreutils
coreutils copied to clipboard
uutils
Disabling compare_xattrs cp and mv related tests on OpenBSD
The test_cp and test_mv have xattr related tests. They should be disabled on OpenBSD after commit 19d42c033923e disabled the compare_xattrs function on OpenBSD.
Related to #6349 Fixes #6348
Back in https://github.com/uutils/coreutils/pull/6349 I silently assumed that you re-ran the tests to verify that the function-removal does not have any knock-on-effects. Thanks for following up on it, though! Let's make uutils work perfectly. :)
Back in #6349 I silently assumed that you re-ran the tests to verify that the function-removal does not have any knock-on-effects. Thanks for following up on it, though! Let's make uutils work perfectly. :)
Right. My mistake. I ran tests before sending the PR but after the suggestion for the removal of the actual compare_xattrs I did it from my OpenBSD machine which does not have the git hooks for automatic tests. Had to push from my linux machine. Installing the hooks on OpenBSD machine to prevent this from happening again.
GNU testsuite comparison:
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Can you please run
cargo fmt?
just did. and added tests and fmt to the hooks.
GNU testsuite comparison:
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Remaining failures are #6275 and #6333 – I'll keep repeating this until we find someone who can fix that problem :)