coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

cksum: Adding the functionality for --zero.

Open orangeng opened this issue 10 months ago • 7 comments

Adding the functionality for --zero / -z. As mentioned in issue #6178

orangeng avatar Apr 02 '24 04:04 orangeng

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Apr 02 '24 05:04 github-actions[bot]

could you please add a test? thanks

sylvestre avatar Apr 02 '24 07:04 sylvestre

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar Apr 02 '24 08:04 github-actions[bot]

Could you check out some of the other utils. I believe we added some functionality for this in uucore. I think it was called LineEnding.

Edit: Here it is: https://docs.rs/uucore/latest/uucore/line_ending/enum.LineEnding.html. It's used in basename for example:

https://github.com/uutils/coreutils/blob/main/src/uu/basename/src/basename.rs#L35

https://github.com/uutils/coreutils/blob/main/src/uu/basename/src/basename.rs#L70-L72

tertsdiepraam avatar Apr 02 '24 12:04 tertsdiepraam

Changed to use LineEnding. As a general question, is there a good way to know if a needed code function is found in uucore and what is not?

orangeng avatar Apr 15 '24 20:04 orangeng

is it ready to be reviewed? Thanks

sylvestre avatar Jun 04 '24 21:06 sylvestre

Unfortunately, school got busy and had to put this aside temporarily. Will be back on this in 1 week.

orangeng avatar Jun 11 '24 08:06 orangeng

Ping :) @orangeng Do you have time to finish this ?

RenjiSann avatar Aug 03 '24 09:08 RenjiSann

@RenjiSann thanks for reminding me haha, I unfortunately don't have time so I will close this PR. Feel free to have a go at it

orangeng avatar Aug 03 '24 23:08 orangeng