coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

`dd`: unset O_DIRECT flag on last chunk if irregular sized

Open cre4ture opened this issue 1 year ago • 35 comments

addresses #6078 (detailed, please read)

cre4ture avatar Mar 15 '24 16:03 cre4ture

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Mar 15 '24 17:03 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

nice :)

sylvestre avatar Mar 15 '24 17:03 sylvestre

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Mar 15 '24 19:03 github-actions[bot]

is it possible to add a test for this? thanks

sylvestre avatar Mar 16 '24 11:03 sylvestre

sure. I can do that. But I have a general question: Is the gnu test enough? Or should we ensure that each functionality that the GNU test-suite validates is also validated by our own test suite?

cre4ture avatar Mar 16 '24 16:03 cre4ture

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

github-actions[bot] avatar Mar 17 '24 17:03 github-actions[bot]

Is the gnu test enough? Or should we ensure that each functionality that the GNU test-suite validates is also validated by our own test suite?

We want to test it with own first. It is much faster to run ours. And way easier to hack.

sylvestre avatar Mar 17 '24 17:03 sylvestre

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

github-actions[bot] avatar Mar 17 '24 19:03 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

github-actions[bot] avatar Mar 17 '24 20:03 github-actions[bot]

could you please rebase this PR? thanks

sylvestre avatar Mar 17 '24 22:03 sylvestre

I will rebase it. But the tests on android are not yet green. Merging needs to wait...

cre4ture avatar Mar 18 '24 22:03 cre4ture

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Mar 18 '24 23:03 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Mar 19 '24 00:03 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 25 '24 21:04 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 26 '24 10:04 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 26 '24 11:04 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Apr 26 '24 13:04 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Apr 26 '24 19:04 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 26 '24 21:04 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 27 '24 12:04 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 27 '24 13:04 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 27 '24 14:04 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 27 '24 15:04 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 27 '24 16:04 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 27 '24 18:04 github-actions[bot]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 27 '24 19:04 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 28 '24 11:04 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 28 '24 11:04 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 28 '24 14:04 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions[bot] avatar Apr 28 '24 15:04 github-actions[bot]