coreutils
coreutils copied to clipboard
sync: Remove crash!
The issue: Remove all uses of crash! https://github.com/uutils/coreutils/issues/5487 Replaced all uses of crash! from the file "src/uu/sync/src/sync.rs" with the show! macro
Please run cargo fmt to format your code.
I don't know if you have seen it: the CI shows some errors on Windows:
error[E0433]: failed to resolve: use of undeclared type `USimpleError`
--> src\uu\sync\src/sync.rs:91:31
|
91 | show!(USimpleError::new(
| ^^^^^^^^^^^^ use of undeclared type `USimpleError`
I think you forgot a use statement.
@daria-tanasie I wonder if you are still working on this. If not, I'd like to make some effort on it.
@tertsdiepraam I would like to open another PR regarding this since this one has been hanging for a while, is that ok?
Sure please go ahead. :)
-------- Message d'origine -------- Le 07/07/2024 11:01, kf zheng a écrit :
@.***(https://github.com/tertsdiepraam) I would like to open another PR regarding this since this one has been hanging for a while, is that ok?
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>
fixed here: https://github.com/uutils/coreutils/pull/6547