coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

`expr`: remove onig

Open tertsdiepraam opened this issue 2 years ago • 4 comments

Step towards: https://github.com/uutils/coreutils/issues/1145

Also relevant: https://github.com/uutils/coreutils/issues/5210

This is an intentional regression. I think we should remove onig in any case and we should either find or implement a pure Rust regex syntax.

tertsdiepraam avatar Nov 09 '23 09:11 tertsdiepraam

GNU testsuite comparison:

GNU test failed: tests/chmod/usage. tests/chmod/usage is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Nov 09 '23 11:11 github-actions[bot]

Before we merge this, we might want to think about this: https://github.com/rust-lang/regex/discussions/1126

tertsdiepraam avatar Nov 09 '23 13:11 tertsdiepraam

needs rebasing

sylvestre avatar Dec 25 '23 10:12 sylvestre

should we close it ? thanks :)

sylvestre avatar Apr 21 '24 07:04 sylvestre