coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

date: fix %Z specifier does not print TZ abbr

Open KrishnaNagam opened this issue 2 years ago • 11 comments

fixes issue https://github.com/uutils/coreutils/issues/3756 for date util

description: chrono crate ignores %Z specifier. only prints timezone offset. added crates chrono-tz and iana_time_zone to calculate the timezone abbreviation and replace %Z specifier with the the abbreviation.

KrishnaNagam avatar Aug 15 '23 17:08 KrishnaNagam

Cool! Having two additional crates is a bit unfortunate, but if that is the best solution it's alright. I think the CI is failing because you didn't push changes to Cargo.lock.

tertsdiepraam avatar Aug 16 '23 06:08 tertsdiepraam

Yeah! chrono v0.5 supposed to have a fix for this. will revisit this once v0.5 is released. https://github.com/chronotope/chrono/issues/970.

BTW, I have pushed the cargo.lock changes.

KrishnaNagam avatar Aug 16 '23 16:08 KrishnaNagam

Still CI is failing. I have enabled Github Actions in my repo to run these tests myself. I will come back once all tests are passed.

KrishnaNagam avatar Aug 17 '23 03:08 KrishnaNagam

Yeah! chrono v0.5 supposed to have a fix for this.

While you're fixing the tests, it might be nice to add a comment with this info to the code.

tertsdiepraam avatar Aug 18 '23 21:08 tertsdiepraam

GNU testsuite comparison:

Skip an intermittent issue tests/tail-2/inotify-dir-recreate

github-actions[bot] avatar Aug 19 '23 09:08 github-actions[bot]

Oops! I accidentally merged main branch again 😅 Now its waiting for CI 😳.

KrishnaNagam avatar Aug 19 '23 17:08 KrishnaNagam

GNU testsuite comparison:

Congrats! The gnu test tests/mv/dir2dir is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate

github-actions[bot] avatar Dec 25 '23 15:12 github-actions[bot]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Feb 02 '24 11:02 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/cksum/md5sum. tests/cksum/md5sum is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/sha1sum. tests/cksum/sha1sum is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cp/same-file. tests/cp/same-file is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/factor/factor. tests/factor/factor is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/timeout/timeout is no longer failing!
GNU test failed: tests/cp/cross-dev-symlink. tests/cp/cross-dev-symlink is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Apr 21 '24 12:04 github-actions[bot]

Is this PR good enough to merge? Please let me know if any changes required.

KrishnaNagam avatar Apr 30 '24 18:04 KrishnaNagam

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar Apr 30 '24 19:04 github-actions[bot]