coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

mktemp: fix PrefixContainsDirSeparator verification

Open ZauJulio opened this issue 2 years ago • 4 comments

  • I belive can resolve #4378 : ]

ZauJulio avatar Feb 16 '23 21:02 ZauJulio

could you please add a test to make sure we don't regress in the future ?

sylvestre avatar Feb 16 '23 21:02 sylvestre

could you please add a test to make sure we don't regress in the future ?

Well remembered, I'll do it as soon as I get back

ZauJulio avatar Feb 16 '23 21:02 ZauJulio

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Feb 16 '23 22:02 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Feb 16 '23 23:02 github-actions[bot]

@ZauJulio ping ? :)

sylvestre avatar Feb 22 '23 20:02 sylvestre

@ZauJulio ping ? :)

Carnival is finally over here in Brazil, I'll upload the test and send it today : ]

ZauJulio avatar Feb 22 '23 20:02 ZauJulio

@ZauJulio ping ? :)

done, I believe that is enough. I loved contributing to the project, I'm going to start my studies in Rust and intend to continue here 🧡

ZauJulio avatar Feb 22 '23 23:02 ZauJulio

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Feb 25 '23 13:02 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/misc/tee. tests/misc/tee is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Feb 26 '23 13:02 github-actions[bot]

GNU testsuite comparison:

GNU test failed: tests/misc/timeout. tests/misc/timeout is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Feb 27 '23 13:02 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

github-actions[bot] avatar Mar 01 '23 20:03 github-actions[bot]

There's a rustfmt issue, but otherwise it's good

show, I just uploaded the fmt correction

ZauJulio avatar Mar 02 '23 18:03 ZauJulio

GNU testsuite comparison:

GNU test failed: tests/misc/timeout. tests/misc/timeout is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Mar 03 '23 20:03 github-actions[bot]

Hi @tertsdiepraam , I was wondering about the current state of PR, do you need anything else? If yes, how can I help you?

ZauJulio avatar Apr 26 '23 16:04 ZauJulio