coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

Migrate from `atty` to `is-terminal`

Open Joining7943 opened this issue 2 years ago • 3 comments

cargo deny gives an advisory warning about atty and it doesn't look like this will be fixed anytime soon because the atty crate doesn't seem to be actively maintained anymore.

is-teminal in contrast is maintained, is a port of atty with this bug fixed and has some additional features. It looks like the better choice and although the api is different, migrating uutils should not be a too big task. It's changing a line with atty::is(atty::Stream::Stdout) to std::io::stdout().is_terminal() (or other streams).

Joining7943 avatar Feb 16 '23 20:02 Joining7943

Also is-terminal is already a dependency of clap, so it's already part of our dependency graph.

tertsdiepraam avatar Feb 16 '23 20:02 tertsdiepraam

If someone isn't already working on it, I'm interested to work on this issue.

souzaguilhermea avatar Feb 16 '23 21:02 souzaguilhermea

Sure, you can go ahead as far as I'm concerned.

Joining7943 avatar Feb 16 '23 22:02 Joining7943