coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

MSRV 1.64 & Workspace inheritance for dependencies

Open tertsdiepraam opened this issue 2 years ago • 1 comments

The first two commits are just bumping the MSRV and fixing the clippy lints.

The last commit is more involved. I'm using the new workspace inheritance method for declaring dependencies. This means that we have a global list of dependencies in the root Cargo.toml that the other crates refer to. If we then want to, for example, bump the version a dependency, we only need to change the version in root Cargo.toml. I think it also creates a clear overview of (almost) all dependencies in the project. There were also many dependencies for which the spec was outdated or where one crate specified it as "0.2" and another as "0.2.3".

I can remove this last commit if you want, but I think it's useful. @sylvestre

tertsdiepraam avatar Feb 11 '23 14:02 tertsdiepraam

GNU testsuite comparison:

Congrats! The gnu test tests/misc/tee is no longer failing!
GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Feb 11 '23 16:02 github-actions[bot]

GNU testsuite comparison:

Congrats! The gnu test tests/misc/tee is no longer failing!
GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Feb 11 '23 18:02 github-actions[bot]

So much better, it will make our life much easier :) many thanks

sylvestre avatar Feb 12 '23 07:02 sylvestre