coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

tail: remove unused "_event_counter"; rename "_timeout_counter" to "timeout_counter"

Open cakebaker opened this issue 3 years ago • 6 comments

This PR removes the _event_counter var. This variable is increased but never read. It also renames the _timeout_counter var to timeout_counter, because the _ at the beginning indicates the var will not be used which is not the case.

cakebaker avatar Nov 29 '22 09:11 cakebaker

I'm currently in the middle of a refactoring of tail here: #3952. Could you please do not change tail until I'm done?

Joining7943 avatar Nov 29 '22 12:11 Joining7943

@Joining7943 Sorry, I wasn't aware of your refactoring work. As this PR is quite trivial, I don't think it will conflict with your work.

cakebaker avatar Nov 29 '22 15:11 cakebaker

I'm currently in the middle of a refactoring of tail here: https://github.com/uutils/coreutils/pull/3952. Could you please do not change tail until I'm done?

I don't think it's efficient to just stop development on tail while that's going on. If conflicts arise we'll just have to deal with that.

tertsdiepraam avatar Dec 02 '22 11:12 tertsdiepraam

I'm just asking for keeping other development on tail than the ongoing refactoring to the necessary minimum. Last 2-3 weeks I was working on UChild instead of the refactoring because it was necessary. However, this kind of stuff won't survive the refactoring anyways and is unnecessary work and complication.

Joining7943 avatar Dec 02 '22 13:12 Joining7943