coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

Add darwin aarch64 for M1 Macs

Open jurgen-kluft opened this issue 2 years ago • 9 comments

A single line addition to CICD.yml

jurgen-kluft avatar Nov 03 '22 08:11 jurgen-kluft

GNU testsuite comparison:

GNU test failed: tests/misc/tee. tests/misc/tee is passing on 'main'. Maybe you have to rebase?

github-actions[bot] avatar Nov 03 '22 14:11 github-actions[bot]

The issue is Warning: cross does not provide a Docker image for target aarch64-apple-darwin,

sylvestre avatar Nov 05 '22 08:11 sylvestre

Yes, seems there are no docker images (yet) for 'aarch64-apple-darwin', so the build can compile but cannot be run. If you want we can close this pull-request for now, until it becomes more clear how to actually test this target?

jurgen-kluft avatar Nov 05 '22 08:11 jurgen-kluft

I found this in the cross README: https://github.com/cross-rs/cross-toolchains.

They cite some licensing issues for not being able to distribute apple images, so I don't think they'll add them any time soon, but I think we could use the cross toolchains.

~By the way, the other apple build does not use cross. Is it not possible to do the same for this target?~ Oh I guess that would not be compatible with GitHub's macos-latest

tertsdiepraam avatar Nov 11 '22 13:11 tertsdiepraam

The only action we could do here is to build it but not run the unit-tests and rely on the other ARM platforms to give us a direction of failing tests? And adding a note in the release notes and or documentation stating that M1 builds are not tested.

Let me know so that we can close this pull-request.

jurgen-kluft avatar Nov 12 '22 01:11 jurgen-kluft

I think just building it is a good temporary solution until GitHub provides M1 runners, which seems to be in the works (https://github.com/actions/runner-images/issues/2187, https://github.com/github/roadmap/issues/528)

tertsdiepraam avatar Nov 12 '22 13:11 tertsdiepraam

I have looked through the CICD setup, but how do I exclude something from test?

jurgen-kluft avatar Nov 13 '22 00:11 jurgen-kluft

I don't think we have an option for that, but I imagine that you could add a new variable to the build matrix to specify whether tests should be run.

tertsdiepraam avatar Nov 13 '22 09:11 tertsdiepraam

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

github-actions[bot] avatar Feb 14 '23 12:02 github-actions[bot]

fails to build for now, please reopen when ready

sylvestre avatar Mar 27 '23 19:03 sylvestre