coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

Fix a TODO by making `conv_block_unblock_helper` consume the input.

Open resistor opened this issue 3 years ago • 5 comments

resistor avatar Aug 07 '22 06:08 resistor

@resistor Nice work here hmm, apart from the linter thing, clippy seems unhappy.

ERROR: `cargo clippy`: this argument is passed by value, but not consumed in the function body (file:'src/uu/dd/src/blocks.rs', line:25)

anastygnome avatar Aug 07 '22 08:08 anastygnome

Also there seems to be a bunch of &buf that make the macos build unhappy

anastygnome avatar Aug 07 '22 08:08 anastygnome

@resistor ping? Thanks

sylvestre avatar Aug 09 '22 07:08 sylvestre

@resistor Nice work here hmm, apart from the linter thing, clippy seems unhappy.

ERROR: `cargo clippy`: this argument is passed by value, but not consumed in the function body (file:'src/uu/dd/src/blocks.rs', line:25)

Done

resistor avatar Aug 10 '22 04:08 resistor

Also there seems to be a bunch of &buf that make the macos build unhappy

Should be resolved as well now.

resistor avatar Aug 10 '22 04:08 resistor

The coverage implies that we don't have a test for this, is that correct?

sylvestre avatar Aug 14 '22 11:08 sylvestre

The coverage implies that we don't have a test for this, is that correct?

I suppose so? I'm not familiar with this functionality.

resistor avatar Aug 16 '22 04:08 resistor

Would it be possible for you to write a test? thanks :)

sylvestre avatar Aug 16 '22 07:08 sylvestre

Done to the extent I can figure out how.

resistor avatar Aug 28 '22 04:08 resistor