coreutils
coreutils copied to clipboard
Fix a TODO by making `conv_block_unblock_helper` consume the input.
@resistor Nice work here hmm, apart from the linter thing, clippy seems unhappy.
ERROR: `cargo clippy`: this argument is passed by value, but not consumed in the function body (file:'src/uu/dd/src/blocks.rs', line:25)
Also there seems to be a bunch of &buf that make the macos build unhappy
@resistor ping? Thanks
@resistor Nice work here hmm, apart from the linter thing, clippy seems unhappy.
ERROR: `cargo clippy`: this argument is passed by value, but not consumed in the function body (file:'src/uu/dd/src/blocks.rs', line:25)
Done
Also there seems to be a bunch of &buf that make the macos build unhappy
Should be resolved as well now.
The coverage implies that we don't have a test for this, is that correct?
The coverage implies that we don't have a test for this, is that correct?
I suppose so? I'm not familiar with this functionality.
Would it be possible for you to write a test? thanks :)
Done to the extent I can figure out how.