uuid icon indicating copy to clipboard operation
uuid copied to clipboard

formatting changes

Open pintariching opened this issue 2 years ago • 3 comments

I'm submitting a refactor

Description

Formatting the codebase a bit by following cargo fmt --check recommendations

Related Issue(s)

#609

pintariching avatar Jul 11 '22 19:07 pintariching

After a bit of formatting cargo fmt --check returns a wall of errors

Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `normalize_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `unstable_features = false`, unstable features are only available in nightly channel.
Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `normalize_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `unstable_features = false`, unstable features are only available in nightly channel.

As stated in #609 I also tried deleting the .rustfmt.toml file but oh boy, cargo was not happy and gave me around 60 diffs. Should I refactor it this way?

pintariching avatar Jul 11 '22 19:07 pintariching

Hi @pintariching :wave:

If you'd like to delete the rustfmt.toml and let those formatting changes come through that sounds good to me. Those are nightly-only configuration toggles and we should probably just use the stable formatter for this library. We haven't been running formatting in CI (I'd much prefer to just run it on merge) so there will be a big diff, but it can live in a single commit.

Thanks for working on this!

KodrAus avatar Jul 28 '22 00:07 KodrAus

It looks like our minimum supported Rust version can't build serde_test anymore. We've been meaning to bump it to 1.57.0, which is around 6 months old now, so I think we can do that here.

If you update this line to 1.57.0 we should be good to go 🙂

KodrAus avatar Aug 11 '22 02:08 KodrAus