jsmpp icon indicating copy to clipboard operation
jsmpp copied to clipboard

Option to Send deliverSmResp manually

Open fjordansilva opened this issue 11 years ago • 2 comments

Modifying the interface MessageReceiverListener, adding a boolean return value to onAcceptDeliverSm the user can choose if JSMPP sends the deliver_sm_resp message once the method has finished or (using FALSE value) doesn't allow to JSMPP to send the message.

This modification is necessary for working with async systems (Vert.x for example). With async system you can not send a response to SMSC because most of the times the original message ( deliver_sm ) has not been processed.

This PR also fix a NullPointer exception that happens when JSMPP tryes to bind to a SMSC that doesn't replay any optional parameter

fjordansilva avatar Oct 06 '13 23:10 fjordansilva

Looks like you made too many trivial changes that it has become hard to find your changes that matter. Try to avoid automatic formatting or changes done by IDE.

ADTC avatar Feb 18 '14 05:02 ADTC

I've copied your pull request into the branch here: https://github.com/opentelecoms-org/jsmpp/commits/fjordansilva-master to see it build in travis

dpocock avatar Jan 06 '15 15:01 dpocock