utterances-oauth icon indicating copy to clipboard operation
utterances-oauth copied to clipboard

CloudFlare config is hardcodded in packages.json

Open galaxy4public opened this issue 4 years ago • 2 comments

I tried to deploy this using yarn run deploy, but it instantly complained that it cannot deploy since it was trying to execute the following command:

cfworker deploy --name utteranc-es --route 'api.utteranc.es/*' src/index.ts

of course this route is not configured in my account since I do not controll that domain.

galaxy4public avatar Apr 09 '20 12:04 galaxy4public

@galaxy4public

The "--name" and "--route" of "deploy" are customized. If you don't configure them in "CloudFlare", you will naturally get an error.

zsdycs avatar May 25 '21 05:05 zsdycs

@zsdycs , this issue is about the hardcoded line in https://github.com/utterance/utterances-oauth/blob/master/package.json#L9 and is for the future enhancement of the deploy procedure where the end-user can actually modify the arguments without editing the source code.

galaxy4public avatar Sep 21 '22 01:09 galaxy4public