crashmonkey icon indicating copy to clipboard operation
crashmonkey copied to clipboard

Put whether a bio is data or metadata in output log

Open ashmrtn opened this issue 8 years ago • 2 comments

#17 and #48 brought in a log file that the failing tests are printed to. This log output contains the indices of the bios in the crash state, and the order they were written out to disk to to form the crash state. This list of indices should be augmented to show whether the bio was a metadata bio or a data bio.

Metadata bios will be denoted by the META flag in the bio itself. Data bios will not have that flag.

Since the amount of data stored in the test result object is minimal at this time, we will likely have to expand the member variable that contains the crash state index information. Expanding that to have <index, data> pairs should suffice.

Sample output for this change could look like/similar to the following:

Test #26 FAILED: file missing: test file has completely disappeared
   last checkpoint: 2
   crash state: 0 (M), 1 (D), 2 (D), 4 (D), 3 (D), 5 (M)

ashmrtn avatar Oct 02 '17 18:10 ashmrtn

@ashmrtn @jayashreemohan29 Is this issue still relevant to CrashMonkey?

vijay03 avatar Apr 22 '20 04:04 vijay03

From a technical perspective it is not required, though it may make debugging certain issues a little easier. The debugging help assumes that file systems properly set the meta flag for changes to their own metadata (I believe that's what this flag is supposed to represent, but I don't think I ever tracked down the actual definition of it).

All changes for this code would be in the userspace portion of CM, specifically focusing on the portion that tracks the test case's crash state.

ashmrtn avatar Apr 22 '20 14:04 ashmrtn