Nikita Koptelov

Results 44 comments of Nikita Koptelov

Now rule `context.TODO()` works as well as `context.TODO`.

Hmm, I've tried to reproduce it but it didn't work. Could you please do `hexdump goban.cfg` and send the result back to me? Maybe there are some non-printable characters in...

Well, since `Field` is a rich `FieldDescriptorMessage` it feels like it should do what rich [Message](https://github.com/grpc-ecosystem/grpc-gateway/blob/master/protoc-gen-grpc-gateway/descriptor/types.go#L60) does for `FieldDescriptorProto` :) It's handy to be able to get Go types for...

Sorry, just remembered about that issue. What should be the proper semantic meaning for `Field.Message`? Right now if I have a binding of `foo.bar.baz.qux`, both `foo.Message`, `bar.Message`, ... are pointing...

Ah, I see :) thank you! We can't switch over to gogo* sadly since it breaks gRPC reflection and enums encoder in vanilla pbjson due to different registries. I'll see...

Thanks, I'll try that. I've just tried the same command (same imports etc) with gogofast though and got same compilation errors...

When I do `protoc -I/usr/local/include -I. -I ./vendor -I vendor/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis --proto_path . --proto_path vendor/github.com/gogo/protobuf/protobuf --gogofast_out=goproto_registration=true,plugins=grpc:. --goclay_out=:. endpoint/pb/*.proto` (i.e. importing gogo proto/proto) it generates even worse import - `import google_protobuf1 "google/protobuf"`

Did it like that: ``` PROTO_MAKER := protoc \ -I/usr/local/include -I. \ -I vendor/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis \ --proto_path vendor/github.com/gogo/protobuf/protobuf \ --proto_path endpoint/pb \ --gogofast_out=plugins=grpc:. \ --goclay_out=:. ``` Import is `google/protobuf/timestamp.proto`. Generation is...

Thank you! Works with that one. I'm leaving the issue open since gofast still doesn't work - but I'll try to fix that if nobody else picks that up.

We could use Go-style operators: `x.bar` - call of `bar` from a package `x` `(*x.Foo).bar` - call of `bar` from a type `x.Foo` however, those look more verbose than the...