godot-kotlin-jvm icon indicating copy to clipboard operation
godot-kotlin-jvm copied to clipboard

Published 20 hours ago • verified publisher icon utopia-rise

Gradle tasks to download an run the pre-compiled binaries

Open Frontrider opened this issue 3 years ago • 3 comments

Added a set of tasks that can download and runs the pre-compiled godot binaries. The default configuration url to download them is the official GitHub, but can be overridden manually. The tasks can download based on your current os, and you can also set the one you want manually. (eg: you want to run the windows version through wine) Includes a set of functional tests for the new tasks, using junit5 and the gradle test kit.

I saw that jcenter is going to go down in february, and it was already throwing me a lot of 502 exceptions so I also had to remove those. I see that it remains read only, but I'd still keep it out of the system. https://blog.gradle.org/jcenter-shutdown

Frontrider avatar Jan 17 '22 11:01 Frontrider

Can you target develop branch please ?

piiertho avatar Jan 17 '22 18:01 piiertho

One for adding tests to gradle plugin, I think that should also target master, but I don't have strong opinion on this one.

Depends. The tests are currently there only for my task. I can make a separate PR with it.

I'll split off the jcenter pr to it's own branch and include that separately.

Frontrider avatar Jan 19 '22 11:01 Frontrider

Regarding separate PR's: I don't have a strong opinion but am more than happy with separate PR's.

Should be, I have not got there to split it so far. I'll attempt to get there next week.

Biggest hurdle i see as well is maintainability. But i think this can be addressed without too much effort.

I tried to keep it to the minimum. That is why I use the unirest library for the download, as using it for this is only a few lines of code, so that kind of overhead is minimal.

Frontrider avatar Jan 29 '22 11:01 Frontrider

I finally finished a "dedicated" plugin that can handle a godot download and execution + a little bit of addon management. I'm running some stability checks on it, that plugin right now does more than what this one should.

Frontrider avatar Nov 11 '22 23:11 Frontrider

I finally finished a "dedicated" plugin that can handle a godot download and execution + a little bit of addon management. I'm running some stability checks on it, that plugin right now does more than what this one should.

Nice! Please link it once/if it's open source :-)

chippmann avatar Nov 14 '22 07:11 chippmann