go-pubsub
go-pubsub copied to clipboard
creating a new client at every status check
Seems we are always creating a new client every time. I think we should do it only once.
https://github.com/utilitywarehouse/go-pubsub/blob/8ce052d68a6fa5630d70668d977541f3cc87b3b5/kafka/status.go#L11
Would you guys accept a PR for this if it does turn out to introduce unnecessary overhead :) ?
We'd consider it of course.
I should let you know though that go-pubsub developement is slowing somewhat now, due to https://github.com/uw-labs/substrate which is intented to eventually replace go-pubsub and address some of it's shortcomings, although substrate still has a few things missing at this point.