uswds-site icon indicating copy to clipboard operation
uswds-site copied to clipboard

Disabled States: Phase 1 guidance rollout

Open jaclinec opened this issue 1 year ago • 22 comments

Phase 1 disabled states site content to update:

Steps required to complete this work

jaclinec avatar Aug 15 '23 21:08 jaclinec

I created a draft of the guidance for those sections of the site and it is ready for content strategy to review, edit, and publish to the site.

jaclinec avatar Aug 15 '23 22:08 jaclinec

@brunerae and @sarah-sch to come back and breakdown this Issue

brunerae avatar Nov 27 '23 20:11 brunerae

Reviewed draft and made comments today. (12/1)

finekatie avatar Dec 01 '23 20:12 finekatie

12/13 discussed with Katie plan to align on text recommendations by end of week and pass on to team for review by 12/18.

sarah-sch avatar Dec 13 '23 16:12 sarah-sch

reviewed draft again after Sarah's work

finekatie avatar Dec 14 '23 22:12 finekatie

Will pass draft to Jacline and accessibility team week of 12/18.

sarah-sch avatar Dec 15 '23 13:12 sarah-sch

12/18 - Passed revisions to @jaclinec and also asked @amycole501 and @alex-hull to review only if they have time. Noting that the team has a lot of time-sensitive work ahead of the Jan. monthly call that is a higher priority right now.

sarah-sch avatar Dec 18 '23 14:12 sarah-sch

I reviewed it and accepted most suggestions and added comments. It's shaping up really nicely!

jaclinec avatar Dec 21 '23 16:12 jaclinec

UX and accessibility reviewed content team's changes week of 12/18. Katie and Sarah giving text one more pass before handing off to fed team for review.

sarah-sch avatar Dec 26 '23 19:12 sarah-sch

Anne has been looking at this with us as of 12/27. Still one or two more queries to resolve.

finekatie avatar Jan 02 '24 18:01 finekatie

This is still in review and will move to next sprint, I suppose?

finekatie avatar Jan 05 '24 20:01 finekatie

@finekatie - Yes, let's move to the next sprint for review by federal team.

sarah-sch avatar Jan 08 '24 14:01 sarah-sch

Let's pick review back up with federal team next sprint. Cc @finekatie

sarah-sch avatar Jan 26 '24 17:01 sarah-sch

@sarah-sch and I discussed today and I took a quick peek. Would like Anne to revisit since there were comments after their last review. @annepetersen can you take a look?

finekatie avatar Jan 29 '24 20:01 finekatie

Will start resolving changes to look at the cleanest closest-to-final copy now

annepetersen avatar Jan 29 '24 20:01 annepetersen

Still a few queries to resolve in there, but it's looking good. Back to you, @sarah-sch and @finekatie.

Realizing that moving to FFR might have been premature, FWIW, but we're still figuring out the details there

annepetersen avatar Jan 29 '24 20:01 annepetersen

@annepetersen - picking this issue back up. I'm thinking it might most expeditious to lay the text out on our first guidance page (progress easily pattern) and get @thisisdano review on the PR. Does that plan work for the fed team? cc @finekatie and @jaclinec

(Posing this question in GitHub as well)

sarah-sch avatar Apr 22 '24 13:04 sarah-sch

Passing to @thisisdano for FFR on 5/1/2024

sarah-sch avatar May 01 '24 16:05 sarah-sch

Literature review had been approved by Dan. Slate review of website update copy by @thisisdano for sprint starting 5/2/2024.

sarah-sch avatar May 20 '24 17:05 sarah-sch

Content approved. Moving back to In Progress to move it into production

thisisdano avatar Jun 07 '24 21:06 thisisdano

hi @brunerae , I'm revisiting. Looks like copy is ready to be added to the site now and I just need to do PRs to get the pages updated. Is that correct?

finekatie avatar Jul 02 '24 16:07 finekatie

Hey @finekatie - correct!!

brunerae avatar Jul 02 '24 18:07 brunerae

First PR created today for Progress Easily: https://github.com/uswds/uswds-site/pull/2744

I also asked team for guidance on where pieces of new content will live. Here's the request I sent today: Hey team, I am ready to work on PRs for adding the Disabled States content to the following pages: Complete a complex form - Progress easily pattern Form templates Form component I was not on the contract when all the initial discussions happened about this. I researched meeting notes but still need help with these things:

  1. For the Progress Easily content, am I adding the What to do and What not to do FIRST in the lists, or at the end of each?
  2. For Form templates, am I adding it first or last in the Accessibility guidance list?
  3. For Form component, the doc says "New section" Disabled states for components in forms" - Am I adding that section AFTER Accessibility guidance, or somewehere else on the page?

I plan to create two other PRs for the other pages. Once I have guidance, I can complete the edits on the PRs and ask for review.

finekatie avatar Jul 05 '24 18:07 finekatie

Any accessibility-related error messaging information should be added with the existing accessibility guidance.

Also: FWIW on the form template page, the guidance around required fields is also considered accessibility guidance. I'm not sure why it's in a separate section without a reference to accessibility.

In general: I suggest adding any relevant WCAG guidance links as references on these pages. The more we can tie in our recommendations to WCAG the better. For example: https://www.w3.org/WAI/WCAG22/Understanding/labels-or-instructions << that's related to required fields.

amycole501 avatar Jul 05 '24 18:07 amycole501

@finekatie:

1.Progress Easily content - Add at the end of the list 2.Form templates - Add at the end of the list 3. Form component - Yes, let's add that section after Accessibility guidance

And I agree with Amy that we might want to rethink/discuss how we want organize content on both the form template and form component pages since disabled states and required fields guidance kinda fall under accessibility.

jaclinec avatar Jul 08 '24 14:07 jaclinec

@finekatie:

1.Progress Easily content - Add at the end of the list 2.Form templates - Add at the end of the list 3. Form component - Yes, let's add that section after Accessibility guidance

And I agree with Amy that we might want to rethink/discuss how we want organize content on both the form template and form component pages since disabled states and required fields guidance kinda fall under accessibility.

Question for @amycole501 and @jaclinec just to clarify: Does this mean I'm still going forward with these changes for now and then we're discussing a content reorg for the pages? Thank you for your patience!

finekatie avatar Jul 08 '24 15:07 finekatie

Yes for now I think you can move forward; we can log this as something to come back to later. Thanks!

amycole501 avatar Jul 08 '24 16:07 amycole501

PR #2744 (progress easily patten) is ready for review

finekatie avatar Aug 11 '24 21:08 finekatie

PR #2775 (form template) is ready for review

finekatie avatar Aug 11 '24 21:08 finekatie

PR: #2776 (form component)is ready for review.

finekatie avatar Aug 11 '24 22:08 finekatie