uswds-site icon indicating copy to clipboard operation
uswds-site copied to clipboard

update parallel text on 404 page

Open bonnieAcameron opened this issue 2 years ago • 2 comments

Description

This PR will close #4225 on uswds-site-- a request to update the language to parallel structure, plain language, and further instruction for the user of what to do next.

Additional information

Closes #4225

Preview link

Preview link: 404 page

Reviewers:

Please review for clarity, typos, and appearance on the page.

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • [ ] Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • [ ] Run npm test and make sure the tests for the files you have changed have passed.
  • [ ] Run your code through HTML_CodeSniffer and make sure it’s error free.
  • [ ] Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

bonnieAcameron avatar Oct 04 '22 17:10 bonnieAcameron

Wondering if the intention for this issue was to also reflect these changes in the USWDS 404 template recommendations.

  • If so, we'd need to complete the following tasks:
    • [ ] update the data in usa-error.json in the USWDS repo.
    • [ ] update the screenshots on https://designsystem.digital.gov/templates/404-page/ (once we have language finalized).
    • [ ] Investigate if the spanish template copy also should be updated (Thinking mostly about the new line about search)

amyleadem avatar Oct 04 '22 21:10 amyleadem

I was wondering the same thing, Amy. Since the request was made over a year ago, I was hesitant to follow up, but if you think those changes to the template itself are good and helpful, I think it would be worth doing. Would you like me to convert them to issues?

bonnieAcameron avatar Oct 05 '22 12:10 bonnieAcameron

I've created two spinoff issues based on your comments and observations, Amy. Please let me know if we're ok to merge on this issue, or if we should hold off until the 404 template is done as well.

bonnieAcameron avatar Oct 24 '22 18:10 bonnieAcameron

Friendly little pingaling on the comment above, @amyleadem :) Can I merge or hold off?

bonnieAcameron avatar Nov 16 '22 19:11 bonnieAcameron

@bonnieAcameron ~~I lean towards tackling this in USWDS first. The main reason is that it would maintain a clearer history of the 404 template if we were able to work through any review and discussion there. Once we finalize there, we can move it into here. Ultimately it can go either way, but this feels like it creates a cleaner record.~~

~~If we want to just get something up for site though, we can go ahead and move this forward as a stopgap and then cycle back later once we update USWDS.~~

~~What do you think?~~

amyleadem avatar Nov 16 '22 20:11 amyleadem

@bonnieAcameron Changing my mind - let's go ahead and finalize copy here and then we can move it to uswds.

I had one outstanding question from an earlier comment.

I wonder if it would be helpful to give users clear instructions on how to search for what they need - maybe just give them directions to use the search bar in the nav?

Wanted to flag that I found the search bar text to be a little confusing since we don't offer them a search bar immediately following that text. I wonder if users (especially those using assistive technologies) might struggle a bit to find the appropriate search bar (assuming the site has a search bar). Wondering if we can modify or remove that text. Curious to hear your thoughts.

amyleadem avatar Nov 21 '22 16:11 amyleadem