MachLine icon indicating copy to clipboard operation
MachLine copied to clipboard

Machline vs Panair Comparison

Open nathanboachie opened this issue 1 year ago • 6 comments

Hi again,

I wanted to know is there any further guidance on running the Panair vs Machline Python script? I understand you need to have Panair installed and the executable within the Machline directory but where specifically does it need to be placed? Are there any other requirements to run the script (python libraries etc..)? Also, does the Python script need to be edited to run the comparison script?

Thanks for the help

nathanboachie avatar Apr 06 '24 14:04 nathanboachie

I will answer your questions as best as I can remember.

As to where the PAN AIR executable needs to be, it should either go in the MachLine root directory or the pan_air_comparison directory. If you can let me know which one is the correct one, I will update the docs. This study does require having panairwrapper installed.

The script shouldn't need to be edited. If you are getting any errors, please post them here, and we can work through them.

corygoates avatar Apr 09 '24 02:04 corygoates

Thanks will try this and get back to you with any issues

nathanboachie avatar May 03 '24 15:05 nathanboachie

I understand the code requires some paraview interface given the line import paraview.simple as pvs, this returns an error when I run the code, did you need to further install any interfaces to run the script? Also it seems as if the panair executable can sit in the pan_air_comparison directory but I will check again if I can overcome this issue. Thanks.

nathanboachie avatar May 21 '24 13:05 nathanboachie

The issue above has been resolved, but I wanted to know how you were able to add scipy to the pvpython environment. Thanks

nathanboachie avatar May 21 '24 17:05 nathanboachie

The comment above has been resolved. In running the comparison code and organising the file structure I have learnt: The .py comparison file needs to be in the Machline root dir, the panair executable needs to be in the pan_air_comparison dir as panair and not panair.exe, there are multiple input files using the old name which is morino/source-free where dirichlet needs to be placed infront of the input files to run as expected.It also seems as if the case_running_functions is missing a function called get_runtime(). I'm assuming this function is used to compare the differences in runtime between the two codes, please could I have it so I can place it within the .py function? Thanks

nathanboachie avatar May 22 '24 13:05 nathanboachie

This function might actually need to be from panairwrapper.py on further inspection

nathanboachie avatar May 22 '24 13:05 nathanboachie

I will update those formulation specifications.

Unfortunately, I do not know what happened to the get_runtime function. I must have modified my local copy of panairwrapper and never pushed that to the remote. I would recommend just commenting out that line.

corygoates avatar May 23 '24 21:05 corygoates

Commented out the time related features and the script now runs fine. Thanks for the help. Also do you understand the difference between ML, MH SH and SL with respect to the orders of convergence plots?

nathanboachie avatar May 25 '24 13:05 nathanboachie

I discuss that pretty thoroughly in Chapter 8 of my dissertation. Have a look through there. https://digitalcommons.usu.edu/etd2023/30/

corygoates avatar May 29 '24 14:05 corygoates

Thanks for the help

nathanboachie avatar May 29 '24 14:05 nathanboachie

No problem!

corygoates avatar May 29 '24 15:05 corygoates