usocket icon indicating copy to clipboard operation
usocket copied to clipboard

LispWorks specific: socket-shutdown on stream-usocket need to pass the stream to comm:socket-stream-shutdown (rather than the socket)

Open Yehouda opened this issue 5 years ago • 2 comments

in backend/lispworks.lisp, the method socket-shutdown on stream-usocket currently calls comm:socket-stream-shutdown on the socket, which is wrrong, because comm:socket-stream-shutdown expects a socket-stream. It needs to pass the stream, that is replace

(socket usocket) by (socket-stream usocket)

Causes two failures when running the regressions tests on LispWorks.

Yehouda avatar Mar 05 '20 12:03 Yehouda

Hi @Yehouda, thanks for your report and sorry for the delay of responses. Not many users actually use the UDP-specific code on LispWorks, as for socket-shutdown I'm not aware of any user even on TCP. Now I'm fixing your reported issues one by one, and I'll make sure the regression tests pass on LispWorks at the end.

For the current issue, I just followed your suggest way and commit a (possible) fix.

binghe avatar Mar 24 '20 11:03 binghe

Ok, thanks. I am actually testing what I get from quicklisp, so will actually test the changes after the next quicklisp release.

Yehouda avatar Mar 24 '20 11:03 Yehouda