pfhub icon indicating copy to clipboard operation
pfhub copied to clipboard

Published 20 hours ago • verified publisher icon usnistgov

Include simulation benchmark review process on development page

Open wd15 opened this issue 7 years ago • 6 comments

Something like:

  • Pull into a local branch and build with Jekyll. If it warns or fails, comment on the PR.
  • Visually check that the PR lives up to its title. Note typos.
  • If it looks good, check the Travis-CI output. If it failed in HTML checking, that's fine.
  • Conduct a code review using GitHub's tools or https://reviewable.io. Try to accept every modified file, not the PR as a whole (reviewable makes this easier).
  • Wait for the developer to respond to your comments or fix objections.
  • Finally, when it's correct, merge on the command line (--no-ff) and push.

wd15 avatar Sep 06 '17 17:09 wd15