oscal-content icon indicating copy to clipboard operation
oscal-content copied to clipboard

Two `this-system` components in the SSP examples.

Open iMichaela opened this issue 3 years ago • 3 comments

Describe the bug

The leveraged ssp and leveraging ssp example have each 2 this-system components. An SSP can have only one this-system component. The error might come from the M3-> RC1 OSCAL up converter.

Who is the bug affecting?

All parties interested in the example

What is affected by this bug?

The accuracy of the example

When does this occur?

Always

How do we replicate the issue?

Exhibit in the example files. We might want to invest time and fix the converter ONLY if there are interested parties.

Expected behavior (i.e. solution)

Only one this-system component is included.

Other Comments

iMichaela avatar Sep 27 '21 18:09 iMichaela

At 10/5 Triage meeting: @iMichaela express interest: validate if this is still an issue.

Arminta-Jenkins-NIST avatar Oct 05 '23 18:10 Arminta-Jenkins-NIST

10/05/2023 analysis

"this-system" is one of many types of components that can be defined in an SSP. OSCAL allows local definitions for the component's type, or can be one of the listed values. OSCAL is not limiting how many components of the same type a system may have, and because of that, OSCAL is not programmatically limiting component with type="this-system" to just one. Logically it makes no sense to have more than one 'this-systemcomponent, especially when each instance ofthis-systemcomponent has a distinctuuid`.

The leveraged and leveraging SSP examples each have two this-system components with distinct uuids.

https://github.com/usnistgov/oscal-content/blob/main/examples/ssp/xml/oscal_leveraging-example_ssp.xml has an extra component at line: 118 autogenerated, in error, by one of our tool. Needs to be removed

https://github.com/usnistgov/oscal-content/blob/main/examples/ssp/xml/oscal_leveraged-example_ssp.xml has an extra component at line: 113 autogenerated, in error, by one of our tool. Needs to be removed

iMichaela avatar Oct 06 '23 01:10 iMichaela

Thanks @iMichaela, I guess we can refine this quickly and then bring it into an upcoming sprint.

/cc @Arminta-Jenkins-NIST

aj-stein-nist avatar Oct 06 '23 13:10 aj-stein-nist