alignn icon indicating copy to clipboard operation
alignn copied to clipboard

compute bond angle cosines inside ALIGNNAtomWise.forward to ensure al…

Open bdecost opened this issue 1 year ago • 1 comments

this PR addresses autograd forces in ALIGNNAtomWise, in light of discussion at #113

  • moves autograd toggle on relative displacement vectors to the start of ALIGNNAtomWise.forward
  • re-computes bond angle cosines inside ALIGNNAtomWise.forward to make sure angle terms are definitely included in the autograd trace

bdecost avatar Jun 13 '23 20:06 bdecost

Hi @bdecost

Currently, I am testing the on the fly line graph option. We can make it as default soon if it works out.

knc6 avatar Aug 11 '23 19:08 knc6