ACVP-Server icon indicating copy to clipboard operation
ACVP-Server copied to clipboard

ACVP-AES-XTS occasionally provides out of range sequence numbers

Open v-roackerman opened this issue 1 year ago • 1 comments

environment Demo

testSessionId 535961

vsId 2509629

Algorithm registration { "algorithm": "ACVP-AES-XTS", "revision": "2.0", "direction": [ "encrypt", "decrypt" ], "keyLen": [ 128, 256 ], "payloadLen": [ 512, 4096, 65536 ], "tweakMode": [ "number" ], "dataUnitLenMatchesPayload": true }

Endpoint in which the error is experienced https://[acvpUrl]/acvp/[endpoint] GET Unsure what you mean.

Expected behavior A sequence number in a range between 0 and 255 be provided.

Additional context ACVP-AES-XTS ACVP documentation dictates that when the tweakMode field is set to “number”, the sequence number shall be between 0 and 255. We sometimes get 256 from the NIST demo server forcing our code to exit.

https://pages.nist.gov/ACVP/draft-celi-acvp-symmetric.html#name-test-groups

v-roackerman avatar Sep 03 '24 22:09 v-roackerman

I found the issue and have fixed it. It will go out with the next version. We'll post here when it's available on demo. Thanks for reporting the issue!

jbrock24 avatar Sep 04 '24 17:09 jbrock24

Hi @v-roackerman, we just deployed the fix for this issue to Demo as part of the v1.1.0.36 release. Are you be able to test it to confirm? Thank you.

livebe01 avatar Oct 07 '24 17:10 livebe01

It is rare that I see it. In fact, after the first time, it was two more months before I saw it again to provide this treport. I will run it regardless as part of my job and report if not fixed.

v-roackerman avatar Oct 07 '24 17:10 v-roackerman

Okay. It was a very straightforward fix. Changing a 256 to a 255.

Ben

On Oct 7, 2024, at 1:10 PM, v-roackerman @.***> wrote:

It is rare that I see it. In fact, after the first time, it was two more months before I saw it again to provide this treport. I will run it regardless as part of my job and report if not fixed.

— Reply to this email directly, view it on GitHubhttps://github.com/usnistgov/ACVP-Server/issues/354#issuecomment-2397466446, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGMA5AXYF3OCTRAT4G6J73TZ2K6A7AVCNFSM6AAAAABNTCPJCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJXGQ3DMNBUGY. You are receiving this because you commented.Message ID: @.***>

livebe01 avatar Oct 07 '24 17:10 livebe01

The fix for this issue has been deployed to ACVTS Prod as part of the v1.1.0.36 release.

livebe01 avatar Oct 15 '24 17:10 livebe01