ACVP-Server icon indicating copy to clipboard operation
ACVP-Server copied to clipboard

multiple ParallelHash MCT issues

Open markowitz-isc opened this issue 2 years ago • 3 comments

vsId PARALLELHASH-128-1.0/prompt.json and PARALLELHASH-256-1.0/prompt.json

Description of Problems

  1. Several of the ParallelHash MCT test group properties appearing in these sample prompt files are not defined in the spec (draft-celi-acvp-xof.html#name-test-groups): minBlockSize, maxBlockSize, minOutLen, and maxOutLen. As they appear to simply echo capabilities registration properties, they're probably unnecessary here.
  2. OTOH, they're referenced in the ParallelHash MCT pseudocode so it's not clear whether they're supposed to be hardcoded in the IUT or read from the prompt file.
  3. The server seems to ignore the MCT test case blocksize property (which strangely enough can be larger than maxBlockSize) and instead uses the group's minBlockSize (as specified in the pseudocode!)... which makes one wonder why there's a blocksize test case property at all. (See draft-celi-acvp-xof.html#name-parallelhash-monte-carlo-te.)

markowitz-isc avatar Jun 05 '22 17:06 markowitz-isc

Sorry we haven't had a chance to get to this yet. Just letting you know that we haven't missed it.

livebe01 avatar Aug 09 '22 20:08 livebe01

Hi @markowitz-isc!

  1. These were missing and added to the docs late June. Thanks for letting us know!
  2. They are meant to be read on a per-case basis by the testing harness.
  3. The group's blocksize (a MathDomain object from registration) is used for the Generation's Hash method, the result's seed's BlockSize is saved to the TestCase as BlockSize (int) for use within the testing harness on a per-case basis.

jbrock24 avatar Jan 25 '23 23:01 jbrock24

Reopening as item #3 appears to be valid

livebe01 avatar Jan 26 '23 15:01 livebe01