cyberpanel icon indicating copy to clipboard operation
cyberpanel copied to clipboard

[BUG] Increamental Backup "Fetch Restore Points" not fetching

Open jodhpurlaxman opened this issue 1 year ago • 2 comments

Describe the bug The page /IncrementalBackups/restoreRemoteBackups not able to list the Snapshots data and throwing the error 500 in console and error on page is "Could not connect to server, please refresh this page". Also, 'IncJobs' object has no attribute 'externalApp' error logged in /home/cyberpanel/error-logs.txt. during the inverstigation i found that the classs IncJobs has no attribute externalApp.

Solutions according to me. Added self.externalApp = '' at line no. 49 at https://github.com/usmannasir/cyberpanel/blob/stable/IncBackups/IncBackupsControl.py#L49 and added externalApp = '' as a second perameters in (https://github.com/usmannasir/cyberpanel/blob/stable/plogical/processUtilities.py#L297) now its working.

To Reproduce What steps did you take when the issue occurred?

  1. added AWS as remote backup destination
  2. Create/Restore Backup with AWS destination
  3. Restore from Remote option generating error while clicking the Fetch Restore Points" as described above.

Operating system: Ubuntu 18.04 LTS

CyberPanel version: 2.3.4 latest

Please let me know if you need more detail from my side.

Thanks

jodhpurlaxman avatar May 09 '23 15:05 jodhpurlaxman

Also the Restoring snapshot backup showing sucess message but not restored one file which was deleted from public_html for testing purpose. I have checked the restic -r "repo" ls "snapshot" its available there. I checked the code and found the disro check function causing this and restore the site code to / instead of /home/

jodhpurlaxman avatar May 10 '23 12:05 jodhpurlaxman

Also, I checked and found that the main backup file has all the files(db, xml and all others), but taking backups too for db and xml. which should be excluded in main backup.

jodhpurlaxman avatar May 27 '23 21:05 jodhpurlaxman