Suggestions

Open hirbod opened this issue 10 years ago • 1 comments

Hi @usmanhalalit

very nice script - really. I like it. It's well programmed, but I want to suggest some improvements.

1. Classes for ul and li should be managed trough config. It's fixed right now
1. disabled should also have prev or next inside, event when "disabled" is added
1. Does not work on pages with base-tag. It just adds ? to the href which will not work. You should set the full path after / or add an option to add a path before.
1. a element inside of li should also have active as class, not only li
1. you can't change the get-variable "page". This should be also editable. I've patched this right now.
1. Some better documentation which config's are available and maybe you could expose more of the API.

I've migrated from an old and bad programmed PaginationIterator, that were the points that made migration a bit more difficult for me.

This suggestions are only for Array, I did not test any other Adapter.

P.S: Nice useage of polymorphism, first open source script out there I've seen so far using this technique. Thanks !

Jul 09 '15 00:07 hirbod

Thanks Hirbod for your appreciation and suggestions. I will definitely try to add/fix these.

Thanks again :)

Jul 30 '15 07:07 usmanhalalit