tania-core icon indicating copy to clipboard operation
tania-core copied to clipboard

Fixes from static analysis found by DeepSource

Open pablojimpas opened this issue 2 years ago • 3 comments

pablojimpas avatar Apr 05 '22 20:04 pablojimpas

What does this PR do @pablojimpas?

bepitulaz avatar Apr 19 '22 16:04 bepitulaz

What does this PR do @pablojimpas?

Sorry for not providing a proper description and mixing different commits in a single PR.

The changes are pretty much well described with the commit messages but overall this PR does not introduce any breaking change, It's mostly "cosmetic" stuff to achieve good, idiomatic and clean Go code. Changes are based on static analysis rules provided by the deepsource.io service. Furthermore, I've removed the dependencies on various logging packages that aren't really necessary and are effectively unmaintained.

Nothing crazy so I guess you can merge it safely now, I plan to work more on quality of life improvements in the Go codebase as well as continue removing unnecessary dependencies to make it more resilient.

pablojimpas avatar Apr 19 '22 21:04 pablojimpas

@bepitulaz ping

pablojimpas avatar May 24 '22 13:05 pablojimpas