strix icon indicating copy to clipboard operation
strix copied to clipboard

feat(agent): make waiting timeout configurable

Open m4ki3lf0 opened this issue 1 month ago • 2 comments

PR Title

Make agent waiting timeout configurable via STRIX_LLM_TIMEOUT #58

Summary

  • teach BaseAgent to resolve a waiting-timeout from config or the new STRIX_LLM_TIMEOUT env var, falling back to the legacy 120 s limit with validation/logging
  • persist the timeout directly on AgentState and update has_waiting_timeout() to respect the per-agent value
  • ensure delegated agents inherit the parent’s timeout by wiring the value through create_agent when constructing child states/configs

Testing

  • Tested by @gabetocci image

m4ki3lf0 avatar Nov 07 '25 22:11 m4ki3lf0

@m4ki3lf0 I just pulled this to a new vm and its not working.

What I tested was a different commit, on a branch called m4ki3lf0/strix/tree/feature/llm-timeout-option and the commit on this branch m4ki3lf0:feature/llm-timeout-config is missing some code changes - and has only 3 files changed.

m4ki3lf0/strix/tree/feature/llm-timeout-option:

$ git log -n1
commit d1eabea1cb3e606bf43c323bddc8fa5712f8df44 (HEAD -> main, origin/feature/llm-timeout-option)
Author: m4ki3lf0 
Date:   Fri Nov 7 16:07:55 2025 +0100

    feat: add configurable llm timeout

$ git diff edd628bbc120a5625646254a6b25ff53875c42f7 --name-only
README.md
strix/agents/base_agent.py
strix/agents/state.py
strix/interface/cli.py
strix/interface/main.py
strix/interface/tui.py
strix/llm/config.py
strix/llm/llm.py
strix/llm/memory_compressor.py
strix/tools/agents_graph/agents_graph_actions.py
$ 

gabetocci avatar Nov 08 '25 12:11 gabetocci

@gabetocci

That should do use STRIX_LLM_REQUEST_TIMEOUT to increase the Request Timeout Delay instead of STRIX_LLM_TIMEOUT (which was previously increase the agents checkin)

@0xallam I think the PR should now be ready for review.

m4ki3lf0 avatar Nov 08 '25 16:11 m4ki3lf0