userver icon indicating copy to clipboard operation
userver copied to clipboard

Change urabbitmq::ConsumerComponentBase::Process signature so that it could receive at least headers and routing key

Open TertiumOrganum1 opened this issue 1 year ago • 2 comments

Currently it has signature: void Process(std::string message); thus we lack queue name, headers and routing key and it is very inconvenient.

TertiumOrganum1 avatar May 27 '24 16:05 TertiumOrganum1

I'd suggest adding another Process override, which takes more data from consumer and by-default just calls Process(std::string). This way we could change consumer implementation to call the newly added method without breaking anyone

itrofimow avatar May 27 '24 16:05 itrofimow

agree

I'd suggest adding another Process override, which takes more data from consumer and by-default just calls Process(std::string). This way we could change consumer implementation to call the newly added method without breaking anyone

TertiumOrganum1 avatar May 27 '24 16:05 TertiumOrganum1

Fixed in https://github.com/userver-framework/userver/commit/7da063b1756575d130707183b056c3d8721f92c7

Many thanks for the repprt and for the PR!

apolukhin avatar May 31 '24 07:05 apolukhin