userver icon indicating copy to clipboard operation
userver copied to clipboard

Published 20 hours ago • verified publisher icon userver-framework

urabbitmq: support setting client + ca certs

Open dyumin opened this issue 10 months ago • 4 comments

This implements https://github.com/userver-framework/userver/issues/514

dyumin avatar Mar 29 '24 15:03 dyumin

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Mar 29 '24 15:03 github-actions[bot]

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/

dyumin avatar Mar 29 '24 15:03 dyumin

recheck

dyumin avatar Mar 29 '24 15:03 dyumin

@itrofimow ping

dyumin avatar May 17 '24 13:05 dyumin

Going forward, please don't just "ping" me -- there are more respectful ways to achieve the same, for one you might want to use "re-request review" github functionality at the top right corner of the page when the review comments are addressed

canvas

dyumin avatar Jun 08 '24 14:06 dyumin

Do you intent to add some tests for the code?

I wasn't planning on adding tests currently.

dyumin avatar Jun 08 '24 15:06 dyumin

@segoon please review

dyumin avatar Jun 10 '24 20:06 dyumin