userver icon indicating copy to clipboard operation
userver copied to clipboard

RabbitMQ (amqp-protocol) support

Open MikhailNazarov opened this issue 2 years ago • 4 comments

Thanks for the long awaited framework. You have done a great job!

I would really like to get support for the async amqp protocol, are there any plans to add it in the near future? Thank you!

MikhailNazarov avatar Jun 26 '22 15:06 MikhailNazarov

I've got a draft that works (unless it crashes randomly upon hard to track down races 😉), which i expect to polish enough to PR in a week or so.

@MikhailNazarov do you have any specific features/perf requirements in mind so i can try to adjust my work accordingly?

itrofimow avatar Jul 14 '22 17:07 itrofimow

RabbitMQ/AMQP experimental support was added, thanks to Ivan Trofimov. We'd appreciate feedback :)

apolukhin avatar Sep 05 '22 14:09 apolukhin

Thank you very much , I will definitely test this feature when I get to this task

MikhailNazarov avatar Sep 05 '22 14:09 MikhailNazarov

Thank you very much , I will definitely test this feature when I get to this task

Hope you'll find it usefull)

Please keep in mind that although i tried pretty hard to test lots of possible scenarios i might've missed some, and since this is not yet used by anyone and implementation wasn't as straightforward as i'd like it to be some bugs might be lurking - if you encounter them please report it either here in issue (preferably) or to my dms.

There are some features that are not yet supported (dynamic-config, headers) and some are lacking (metrics, some tests), but sadly i didn't have enough free time to implement them right away. Feel free to file an issue if you need any enhancements

itrofimow avatar Sep 05 '22 14:09 itrofimow

Looks like the support for AMPQ is fine. Closing this issue, improvements would be done in a separate issues/PRs.

apolukhin avatar Oct 25 '22 12:10 apolukhin