userver icon indicating copy to clipboard operation
userver copied to clipboard

`http_parser` is unmaintained

Open itrofimow opened this issue 2 years ago • 2 comments

See https://github.com/nodejs/http-parser/issues/522

There is https://github.com/nodejs/llhttp with very similar API (although llhttp is missing the URL parser functions from http-parser), so we could switch to it pretty easily, and it also promises massive perf improvements

itrofimow avatar Nov 01 '22 21:11 itrofimow

Sound great. But we have to keep supporting http_parser as long as most of the distros do not get support for the llhttp

apolukhin avatar Nov 05 '22 15:11 apolukhin

We can vendor it in third_party, and thats what most people who switched do - llhttp has c sources in releases .tar since v6 or smth, so it should be as easy as FetchContent: https://github.com/nodejs/llhttp#using-with-cmake

itrofimow avatar Nov 05 '22 15:11 itrofimow

Addressed by https://github.com/userver-framework/userver/commit/e6b635c1a0ee2c2a70f9bd909c478f14c8df82c8

itrofimow avatar Mar 20 '24 13:03 itrofimow