Joaquín Sánchez

Results 1398 comments of Joaquín Sánchez

We need to fix all cjs files generated by `unbuild`, cjs files generated with `tsup` should be fine. You should create a new script in scripts folder and call it...

yes, the script should fix all cjs files in all packages, `unocss` will include a few of them (and so you don't need to install individual packages if you only...

We also need to add `typesVersions` to all packages exporting submodules, this way we can remove all d.ts files in the root folder: for example, `preset-icons` is failing, dts files...

For example, removing browser.dts and including both entries in package.json: ![imagen](https://github.com/unocss/unocss/assets/6311119/6cae9097-a1bf-4f83-aaa1-711def033bc0) ![imagen](https://github.com/unocss/unocss/assets/6311119/edc37746-bda5-493e-a548-23040781a802)

@kwaa thx, maybe tmr this PR is merged ;)

Don't remove dts files I will review tmr

@kwaa rn I'm checking it... Unfortunately the cli to check the TGZ does not work for me on my Windows, trying by hand

Adding patch to tsup cjs/d.cts files, for runtime package: ![imagen](https://github.com/unocss/unocss/assets/6311119/a8872e5d-deaf-44b0-94ce-7ce075a40de6)

@kwaa fixed a few packages, about vite and svelte-scoped: reverted CJS to Masquerading as ESM, I'll check Vite package to split entries. I need to review the following packages: -...

uhmm, I need to exclude dts file in scope package, it is just a hack...