Joaquín Sánchez

Results 1398 comments of Joaquín Sánchez

This plugin cannot do anything about this, sentry plugin adding the import, workbox will build the sw using `importScripts` and we cannot use `type: "module"` and `importScripts` ![imagen](https://github.com/vite-pwa/nuxt/assets/6311119/840c67d6-d421-4567-b283-9d0536e2d9f6)

`vite-pwa-plugin` is not transforming the sw in dev, it just generate it calling workbox-util package, sentry is intercepting that request. I have no idea why sentry release adding the import,...

> I have no idea why sentry release adding the import, it seems that match this, and so adding it: upps, using filename (removes the query param): `var idWithoutQueryAndHash =...

> Or we cannot use @sentry/vite-plugin with vite-pwa/nuxt? You can but using `injectManifest` strategy, Vite will inline the dependency when building it (in dev will just remove ts annotations via...

@MaxWeisen ![imagen](https://github.com/vite-pwa/nuxt/assets/6311119/280b521e-18bd-43ab-b61a-55520a74841a) ![imagen](https://github.com/vite-pwa/nuxt/assets/6311119/eb4ea3df-4a27-420a-8a72-57794ba2f830)

I'll send you a PR to your repro and so you can see the changes, I'm finishing some tests like build the sw.

@MaxWeisen in dev there is no offline support, the manifest entries will have only the navigate fallback or `/` with a random revision, here the build with the sentry import...

@MaxWeisen https://github.com/MaxWeisen/vite-pwa-sentry-plugin-issue/pull/1 We'll need to prerender the navigate fallback. Since your repo not using pages... update changes properly. Remove `minify: false,` from `injectManifest` in your repo, in the repro just...

I forgot to mention I also added the sentry plugin to the build, you can remove it: just remove this entry https://github.com/MaxWeisen/vite-pwa-sentry-plugin-issue/pull/1/files#diff-5977891bf10802cdd3cde62f0355105a1662e65b02ae4fb404a27bb0f5f53a07R47-R55

You can check any custom sw in the vite pwa plugin examples folder or here in nuxt playground: check also a working (production) example with some runtime caching entries and...