Joaquín Sánchez

Results 1398 comments of Joaquín Sánchez

On Windows fs you cannot use `:` in the name (iirc in any fs).

Don't remove `refreshing` flag, if you're testing it via Chrome Dev Tools `Update on Reload` button: ```ts let refreshing; navigator.serviceWorker.addEventListener('controllerchange', function() { if (refreshing) return; refreshing = true; window.location.reload(); }...

If PWA is installed, check you've disabled clearing app data from Android settings

@antti5 try adding this entry to vite define: ```js define: { 'process.env.NODE_ENV': process.env.NODE_ENV === 'production' ? '"production"' : '"development"' } ```

You can add rollupFormat iife in the injectManifest option, check the pr to add a new vite build: it is a bug with esbuild

@antti5 can you shared small repro? I can test it with #629

Why do you need that import? You can use `SW_BUILD_DATE` in Vite define entry + `declare const SW_BUILD_DATE: string` in some dts ![imagen](https://github.com/vite-pwa/vite-plugin-pwa/assets/6311119/b02f070b-cd9c-49b8-b303-f034888531d1) ![imagen](https://github.com/vite-pwa/vite-plugin-pwa/assets/6311119/3f8b4e0f-6137-439d-aef8-7102dcb2e3aa)

anyway, the build time is wrong in your code, you need to provide it in the build

`preval.macro` is CJS only, `babel-plugin-preval` is CJS only (with wrong package exports), the problem is about using `babel-plugin-macros` it seems a node only package (using `path` and `process`), this shouldn't...