Joaquín Sánchez
Joaquín Sánchez
Should we add the hover effect on mobile screen?
Review gitlab and bitbacket svg icons, links in the css: - gitlab: https://icon-sets.iconify.design/akar-icons/gitlab-fill/ - bitbacket: https://icon-sets.iconify.design/pajamas/bitbucket/
> How do I do that What do you mean?
what do you mean with a basePath? Setting the base at vite config file to `base: '/sample/'` works, the icon is relative to the webmanifest, it is at root. 
If you change the `basePath` after build, you will have problems since the pwa will configure sw scope at build time, rn cannot be changed at runtime.
To check the webmanifest you only need to add the plugin with empty options (the plugin will add some entries from the package.json), just enable dev options and test it...
how can we test your repro? on my local I cannot see any performance slow down when loading the page. Is it about running dev server or build + preview?
Can you try using passive modifier on click handler?. Can you show performance details centered in 4s? Can you check if lodash-es being tree shaked? I always use the subpackage...