Aditya Chaudhary
Aditya Chaudhary
Ready for review!
hey I would like to take on this issue as this is stale till now.
The test are *Failing* now, because the story shots are not updated, if the changes looks good I will update it shortly.
> Hii @userAdityaa this PR doesn't seem to work for me, I type in the filter but the URL doesn't update Hey @ashu8912, this PR currently handles filtering only for...
> also the search bar seems to be always open now Yes, I’ve already mentioned this issue in the PR description, but I’ll try to address it as well before...
The SearchBar option is now back to normal. I've updated the filter in most of the `List.tsx` and `Overview.tsx` files, though a few are still pending. I'll complete those updates...
It's now ready for next round of review. I have taken all the previous feedback into consideration.
> Very cool. Thanks. > > By the way... I think we have a confusion. To me deleting a cluster means deleting it. If delete just removes it from the...
> Looking good. > > Would you mind putting the locale changes into each commit where the change happens? This way each commit will pass tests and therefore be atomic...
Hey @skoeva, It's ready for another round of review. #### Changes include: 1. Modified the screenshots with new one containing both Delete and Remove. 2. Changed commit and PR title...