user27182

Results 489 comments of user27182

@banesullivan @tkoyama010 Is there still a desire to get this patch merged? In terms of the technical changes and fixes listed in the top comment?

Ok thanks. The technical changes are ready but the documentation and any warnings in code have not yet been updated. Please make suggestions for this as I'm not sure what...

I think excluding `TYPE_CHECKING` blocks should be allowed, e.g. we can safely ignore coverage for this (from #5715 ): https://github.com/pyvista/pyvista/blob/fb59e1c659a4f41a89c456bf1198ea975638d101/pyvista/__init__.py#L67-L74

Has anyone been able to download the docs lately? It takes about 2hrs to download and keeps failing for me part way through. ![image](https://github.com/pyvista/pyvista/assets/89109579/d2d3d73f-bcbb-4205-8972-48d94c3055db)

Might be worth considering using [sphinx-remove-toctrees](https://github.com/executablebooks/sphinx-remove-toctrees). Apparently having lots of auto-generated cross-references from toctrees can slow build times considerably as it takes time to resolve all the cross-references. See also...

Another possible solution for this: allow selectively building only part of the docs with CLI options. E.g. pandas has a mechanism like this, see: https://pandas.pydata.org/docs/development/contributing_documentation.html#building-the-documentation Link to the pandas `make.py`...

[Linux Unit Testing (3.9, 9.1)](https://github.com/pyvista/pyvista/actions/runs/7922621289/job/21630612205?pr=5571): `tests/plotting/jupyter/test_trame.py::test_trame_plotter_ui[vue3] Fatal Python error: Fatal Python error: Segmentation fault` Same as above, but `vue3` instead of `vue2`

This one is fairly common: [docstring check](https://github.com/pyvista/pyvista/actions/runs/7922757263/job/21631067065?pr=5633) `FAILED pyvista/core/filters/data_set.py::pyvista.core.filters.data_set.DataSetFilters.pack_labels` There's an open PR for it: #5290